[PATCH] Fix compilation without SMI code

[Panagiotis Issaris]

Hi,

Gilles Chanteperdrix wrote:

>Panagiotis Issaris wrote:
> > So, compiling without SMI code is not supposed to happen?
>
>Could you try this patch and tell me if it works ? Thanks in advance,
>and thanks for pointing out the bug, by the way.
>  
>
My pleasure.

The patch doesn't work because the file smi.h is not
symlinked into the build directory as hal.c is.

Personally -but that's just my humble opinion- I think leaving the
call to rthal_smi_init in the hal.c file and having it removed by
the preprocessor is a little bit confusing. Because
when reading hal.c it seems as if rthal_smi_init is called no
matter what.

In a similar fashion, having f.e. rthal_ppc_init() calls in x86 or
general code would be confusing even if the code was removed
by the preprocessor behind the screens.

With friendly regards,
Takis

-- 
------------------------------------------------------------------------
Panagiotis Issaris
Katholieke Universiteit Leuven
Division Production Engineering,
Machine Design and Automation
Celestijnenlaan 300B              panagiotis.issaris at mech.kuleuven.ac.be
B-3001 Leuven Belgium                 http://www.mech.kuleuven.ac.be/pma
------------------------------------------------------------------------